Rework how email verification works #3784
Open
+4,659
−3,470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
ef74d47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://573581ef.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-optional-email.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/optional-email
branch
2 times, most recently
from
58f4749 to
59170a3
Compare
sandhose
force-pushed
the
quenting/design-review-jan-25
branch
from
e708212 to
7c57d09
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
59170a3 to
73f2840
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
73f2840 to
89082a7
Compare
This considers all user_emails as confirmed, and removes the verification code. It will be replaced by a new email authentication code flow
sandhose
force-pushed
the
quenting/optional-email
branch
2 times, most recently
from
bda2b00 to
5638b67
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
5638b67 to
d65286d
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
45d4218 to
24999ef
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
24999ef to
a39e1d3
Compare
sandhose
force-pushed
the
quenting/optional-email
branch
from
a39e1d3 to
ef74d47
Compare
sandhose
added
A-Registration-Flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely redesigns how email verification works.
Fixes #3112
Fixes #2881
Helps with #1505
This is meant to be reviewed commit by commit
As per the task list bellow, it's missing a few little things, but those are details that can be tackled later, and I'll open individual issues for them.
Tasks
Quick screen recording on how it looks:
output.mp4